Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features: LJGEN_SOFTCORE implies LENNARD_JONES_GENERIC. #2337

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Features: LJGEN_SOFTCORE implies LENNARD_JONES_GENERIC. #2337

merged 1 commit into from
Oct 26, 2018

Conversation

KaiSzuttor
Copy link
Member

Fixes #2331

@codecov
Copy link

codecov bot commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #2337 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2337    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         380     381     +1     
  Lines       18842   18918    +76     
=======================================
+ Hits        13497   13589    +92     
+ Misses       5345    5329    -16
Impacted Files Coverage Δ
src/core/virtual_sites.cpp 80% <0%> (-2%) ⬇️
src/script_interface/lbboundaries/LBBoundary.hpp 75% <0%> (-1%) ⬇️
src/core/grid_based_algorithms/lb.hpp 71% <0%> (-1%) ⬇️
src/core/collision.cpp 81% <0%> (-1%) ⬇️
...c/core/unit_tests/ParallelScriptInterface_test.cpp 100% <0%> (ø) ⬆️
...rc/core/utils/serialization/CUDA_particle_data.hpp 100% <0%> (ø) ⬆️
src/core/utils/math/tensor_product.hpp 100% <0%> (ø) ⬆️
src/core/cuda_init.cpp 0% <0%> (ø) ⬆️
src/core/MpiCallbacks.cpp 100% <0%> (ø) ⬆️
src/core/PdbParser.cpp 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1ebd2...539d18f. Read the comment docs.

@KaiSzuttor KaiSzuttor added this to the Espresso 4.0.1 milestone Oct 26, 2018
@RudolfWeeber
Copy link
Contributor

Can be merged

@KaiSzuttor KaiSzuttor merged commit 6944131 into espressomd:python Oct 26, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Oct 26, 2018
@KaiSzuttor @RudolfWeeber
Merge pull request espressomd#2337 from KaiSzuttor/non_bonded_test
7a25484 
Features: LJGEN_SOFTCORE implies LENNARD_JONES_GENERIC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Espresso 4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiSzuttor @RudolfWeeber